Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added experimental terminal integration #13631

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add terminal Integration #6235

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
image

@files-community files-community locked and limited conversation to collaborators Nov 1, 2023
@yaira2 yaira2 changed the title Feature: Added terminal integration Feature: Added experimental terminal integration May 1, 2024
@yaira2
Copy link
Member

yaira2 commented May 1, 2024

I had some notes on this but I'll have another look since it's been a while.

@yaira2
Copy link
Member

yaira2 commented May 1, 2024

The main point to figure out before merging is whether the terminal is global, or if there can be a separate terminal for each tab & pane. I lean towards the second option (similar to VS Code).

@gave92 gave92 marked this pull request as draft May 2, 2024 06:56
@gave92
Copy link
Member Author

gave92 commented May 2, 2024

Holding off while @hez2010 checks if it's possible to use Windows Terminal control.

@gave92
Copy link
Member Author

gave92 commented May 8, 2024

Added ability to have more than one terminal 😇

@yaira2 yaira2 self-assigned this May 8, 2024
@yaira2
Copy link
Member

yaira2 commented May 8, 2024

Switching between terminals is working nicely!

@gave92 gave92 marked this pull request as ready for review May 9, 2024 05:29
Copy link
Contributor

@XTorLukas XTorLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add localized text and tooltip to the buttons 😊

src/Files.App/UserControls/StatusBar.xaml Show resolved Hide resolved
src/Files.App/UserControls/StatusBar.xaml Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Show resolved Hide resolved
src/Files.App/UserControls/StatusBar.xaml Show resolved Hide resolved
src/Files.App/UserControls/StatusBar.xaml Show resolved Hide resolved
src/Files.App/UserControls/StatusBar.xaml Show resolved Hide resolved
@yaira2 yaira2 marked this pull request as draft May 28, 2024 01:48
-ms-content-zooming: none;
}

#terminal-container {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaira2 you might want to try here.

border-radius: 8px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add terminal Integration
6 participants