Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Use RichCommands in home and sidebar #15329

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 7, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Right click widget item (use those three commands)
  3. Right click sidebar item (again)

Confirmed it's working
image

@yaira2
Copy link
Member

yaira2 commented May 7, 2024

Are the sidebar contexts hidden from the command palette and actions page?

@0x5bfa
Copy link
Member Author

0x5bfa commented May 8, 2024

Ouch, I forgot to do that, will do.

@0x5bfa
Copy link
Member Author

0x5bfa commented May 9, 2024

Done

@0x5bfa 0x5bfa closed this May 16, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-BroaderRichCommandUsage1 branch May 16, 2024 05:34
@0x5bfa 0x5bfa restored the 5bfa/CQ-BroaderRichCommandUsage1 branch May 16, 2024 05:35
@0x5bfa 0x5bfa reopened this May 16, 2024
@yaira2 yaira2 requested a review from hishitetsu May 28, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants