-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert academic honstey tests to Playwright #54855
base: main
Are you sure you want to change the base?
feat: convert academic honstey tests to Playwright #54855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sembauke, this looks good. We can take the opportunity to tidy things up, though:
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sem. Could you change that one expect, please?
I can't directly use the translations as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the conflict is fixed
Checklist:
main
branch of freeCodeCamp.Closes #XXXXX