TEST execute dom Sanity tests with a single instance #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to keep track of a very annoying problem which we could not understand yet.
Currently, the testsuite of the DOM executes each test isolated, by calling ghdl-dom as an external program. It ensures that each file is analysed on its own. We did so because of the problems we had when analysing too many files. Those problems are solved now, so we don't need to keep using
executablefromsys.However, for some unexplained reason, if we do "reuse" the instance some other apparently unrelated tests in other files do fail. Precisely,
pyunit/dom/SimpleEntity.pyandpyunit/dom/SimplePackage.pyfail, despite the change in this PR being related topyunit/dom/Sanity.py.We don't know whether that's related to libghdl, pyGHDL or pytest. This is not a regression, but something we avoided since the beginning (#1797 (comment)).