Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix '-Wunused' warning in ieee.numeric_std #2200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kammoh
Copy link
Contributor

@kammoh kammoh commented Sep 27, 2022

Just to get rid of the superfluous warning which pops up in every elaboration, when using -Wunused warning switch and VHDL < 2008.

../../src/ieee/v93/numeric_std-body.vhdl:2373:14:warning: variable "value" is never referenced [-Wunused]

Description Please explain the changes you made here.
If the feature changes current behaviour, explain why your solution is better.

🚨 Before submitting your PR, please read contribute in the Docs, and review the following checklist:

When contributing to the GHDL codebase...

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that GHDL can be successfully built. See Building GHDL.
  • CONSIDER adding a unit test if your PR resolves an issue.
  • CONSIDER modifying the docs, if your contribution is relevant to any of the content.
  • AVOID breaking the continuous integration build.
  • AVOID breaking the testsuite.

When contributing to the docs...

  • DO make sure that the build is successful.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

❤️ Thank you!

```
../../src/ieee/v93/numeric_std-body.vhdl:2373:14:warning: variable "value" is never referenced [-Wunused]
```
@tgingold
Copy link
Member

tgingold commented Sep 27, 2022 via email

@inkdot7
Copy link

inkdot7 commented Jan 5, 2023

Perhaps this commit could be rebased onto current master, to see if the tests are ok?
(I'm seeing the same and a few more warnings about unused, so would be nice to solve this.)

@tgingold
Copy link
Member

tgingold commented Jan 6, 2023

Do you have a testcase that shows this warning ?

@inkdot7
Copy link

inkdot7 commented Jan 6, 2023

When running with docker image ghdl/vunit:gcc, the following

a.vhd.txt
build.sh.txt

gives

err.txt

@tgingold
Copy link
Member

tgingold commented Jan 6, 2023

Thank you for the reproducer. I am testing a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants