Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Add some method calls as a Source #16471

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Sim4n6
Copy link
Contributor

@Sim4n6 Sim4n6 commented May 12, 2024

No description provided.

@Sim4n6 Sim4n6 requested a review from a team as a code owner May 12, 2024 08:47
@github-actions github-actions bot added the Ruby label May 12, 2024
@sidshank sidshank changed the title Add some method calls as a Source Ruby: Add some method calls as a Source May 13, 2024
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just wondering about the match against objects.rb.

@Sim4n6 Sim4n6 requested a review from aibaars June 7, 2024 07:36
@aibaars
Copy link
Contributor

aibaars commented Jun 10, 2024

@Sim4n6 There seems to be a change in the expected output from the tests. Could you verify and update the test data if needed?

@Sim4n6
Copy link
Contributor Author

Sim4n6 commented Jun 10, 2024

Hey,

Well, I don't know what is the issue right away. So I updated the Codeql cli to 2.17.4 and I rerun the codeql test learn to regenerate the expected file 7c0ce64

I am available right away to fix this issue, please explain more thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants