C#: Fix performance issue in EntityFramework modelling #16473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
previously approved these changes
May 15, 2024
hvitved
force-pushed
the
csharp/entity-framework-perf
branch
from
9cd7dc0
to
d9019f9
Compare
tamasvajk
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a perfomance issue in how we model flow through EntityFramework
SaveChangesmethods. When data reaches aSaveChangesmethod call, we jump (usingSyntheticGlobals) to the relevantDbSet<elementType>properties, and we were previously storing unnecessarily much information in theSyntheticGlobals, which could result in a combinatorial explosion.