C#: Update non-Roslyn thirdparty dependencies #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that `dotnet paket update` will pull in the latest matching versions of all dependencies, except the pinned roslyn versions. GitInfo also remains pinned, as we're removing that dependency when converting the build to bazel anyways. This removes a whole bunch of transitive dependencies we no longer need, resulting in a smaller distribution, and hopefully a smaller build.
criemen
force-pushed
the
criemen/update-deps
branch
from
91ea3dc
to
47f679d
Compare
michaelnebel
approved these changes
May 16, 2024
There was a problem hiding this comment.
This looks good to me, but I would also like to hear if @tamasvajk has any reservations that we only pin Roslyn.
|
To be clear, we're "pinning" the other deps still via the lockfile, so updating those need a |
tamasvajk
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that
dotnet paket updatewill pull in thelatest matching versions of all dependencies, except
the pinned roslyn versions.
GitInfo also remains pinned, as we're removing that
dependency when converting the build to bazel anyways.
This removes a whole bunch of transitive dependencies
we no longer need, resulting in a smaller distribution,
and hopefully a smaller build.
We leave the Roslyn dependencies fixed, as that's a more involved process to upgrade.