Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Inline expectation for model generator test. #16477

Merged
merged 8 commits into from
May 22, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented May 13, 2024

In this PR we refactor the C# model generator test to inline like verification (models should be inlined as comments above a callable).

@@ -0,0 +1,18 @@
private import csharp as Cs

Check warning

Code scanning / CodeQL

Names only differing by case Warning

Cs is only different by casing from CS that is used elsewhere for modules.
@michaelnebel michaelnebel marked this pull request as ready for review May 14, 2024 08:34
@michaelnebel michaelnebel requested review from a team as code owners May 14, 2024 08:34
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label May 14, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@michaelnebel michaelnebel merged commit 84e412f into github:main May 22, 2024
32 checks passed
@michaelnebel michaelnebel deleted the csharp/madinlinetest branch May 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants