Go: Improve log messages in buildWithoutCustomCommands
#16480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out in #16469, the log message in
buildWithoutCustomCommands
that reads "Build failed, continuing to install dependencies" is confusing for users since it doesn't actually mean that we failed to build a project. It just means that we failed to find or run a build script such as aMakefile
.What this PR does
This PR fixes #16469 by:
Autobuild
function to also return an array of scripts that were executed.