Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Improve log messages in buildWithoutCustomCommands #16480

Merged
merged 5 commits into from
May 15, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented May 13, 2024

Summary

As pointed out in #16469, the log message in buildWithoutCustomCommands that reads "Build failed, continuing to install dependencies" is confusing for users since it doesn't actually mean that we failed to build a project. It just means that we failed to find or run a build script such as a Makefile.

What this PR does

This PR fixes #16469 by:

  1. Improving the wording of the log message.
  2. Modifying the Autobuild function to also return an array of scripts that were executed.
  3. Improving the log messages further by checking the length of that array to see whether any scripts were found or not.

@mbg mbg self-assigned this May 13, 2024
@mbg mbg requested a review from a team as a code owner May 13, 2024 11:44
@github-actions github-actions bot added the Go label May 13, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, one style nitpick

go/extractor/cli/go-autobuilder/go-autobuilder.go Outdated Show resolved Hide resolved
@mbg mbg requested a review from smowton May 13, 2024 14:35
@mbg mbg requested a review from owen-mc May 15, 2024 08:39
@mbg mbg merged commit 964b3f2 into main May 15, 2024
12 checks passed
@mbg mbg deleted the mbg/go/improve-script-fail-message branch May 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go Autobuild failure reason unclear
3 participants