C#: Lift models. #16484
Merged
C#: Lift models. #16484
+188
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,18 @@ | |||
| private import csharp as Cs | |||
Check warning
Code scanning / CodeQL
Names only differing by case Warning
michaelnebel
force-pushed
the
csharp/superimplmodelgen
branch
2 times, most recently
from
ce24cbe
to
c2796a9
Compare
|
|
michaelnebel
force-pushed
the
csharp/superimplmodelgen
branch
2 times, most recently
from
39cc38a
to
8c6dcbc
Compare
michaelnebel
force-pushed
the
csharp/superimplmodelgen
branch
7 times, most recently
from
bca48ac
to
ab3ad36
Compare
…pt for the implicit methods on Object and ValueType.
michaelnebel
force-pushed
the
csharp/superimplmodelgen
branch
from
ab3ad36
to
c59c7cf
Compare
michaelnebel
added
the
no-change-note-required
hvitved
requested changes
May 28, 2024
csharp/ql/src/utils/modelgenerator/internal/CaptureModelsSpecific.qll
Outdated
Show resolved
Hide resolved
hvitved
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we align the C# model generator lifting and override logic with Java.
That is,
ObjectandValueTypeas this causes issues when generating models for .NET runtime (as these class definitions are included in the .NET runtime source code).ObjectandValueType(as class or value type implicitly extend these).Furthermore, we also make a small fix related to sink model discovery. We only want to exclude generation of these, if there exist a neutral sink model (and not a neutral summary model).