Python: Rich type column in MaD
#16490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
force-pushed
the
python/rich-type-column-MaD
branch
from
973e09a
to
21b0dd3
Compare
yoff
force-pushed
the
python/rich-type-column-MaD
branch
from
21b0dd3
to
d4d6b48
Compare
tausbn
requested changes
May 17, 2024
| bindingset[type] | ||
| private predicate parseType(string type, string typePath, string suffix) { | ||
| exists(string regexp | | ||
| regexp = "([^!]+)(!|)" and |
There was a problem hiding this comment.
Is (!|) different from (!?) somehow? (Apart from the latter expressing some level of surprise. 😅)
There was a problem hiding this comment.
I must admit that I just copied the Ruby one...I kind of like the surprised version :-)
python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModelsSpecific.qll
Outdated
Show resolved
Hide resolved
tausbn
previously approved these changes
May 17, 2024
Co-authored-by: Taus <tausbn@github.com>
tausbn
approved these changes
May 17, 2024
I kicked off a DCA run, but you are right that it might not show much until we really start using this... |
|
The DCA run showed no degredation (no chnage at all, really, as expected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a dotted path in the
typecolumn of a MaD row. This means that- ["foo", "Member[MS_Class].Instance.Member[instance_method]", "Argument[self]", "ReturnValue.TupleElement[0]", "value"]can now be written
- ["foo.MS_Class", "Member[instance_method]", "Argument[self]", "ReturnValue.TupleElement[0]", "value"]see the rewritten test models for more examples.