-
Notifications
You must be signed in to change notification settings - Fork 58.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publishing-docker-images.md workflow samples #32820
Conversation
The [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) requires `id-token: write` permissions.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@CosminLazar Thanks so much for opening a PR! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
Hey @CosminLazar, thank you so much for catching this and updating the docs! I came across #32926 before I saw your PR, which made the exact same changes. Since I merged that PR, I'm just going to close this one out. Thanks again for helping us improve our docs. 💛 |
Why:
The actions/attest-build-provenance requires
id-token: write
permissions.What's being changed (if available, include any code snippets, screenshots, or gifs):
Just added the
id-token: write
to the permissions of the workflow showed as an example.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.