Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an Express.gitignore file to my own branch named my-own-branch - by / chprince11 #4432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −0
Open

Added an Express.gitignore file to my own branch named my-own-branch - by / chprince11 #4432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718b21f
Exprees-gitignore
chprince11 Apr 14, 2024
733cf27
Added-Express.gitignore
chprince11 Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 36 additions & 0 deletions Express.gitignore
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a little more detail on Express and references backing up your choices in the ignore template?
Official docs and/or examples of popular Express .gitignore files are good options.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sir. Of course, I will make the changes soon, maybe tomorrow.

@@ -0,0 +1,36 @@
# Logs
logs
*.log

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Node.js dependencies
node_modules/

# Optional npm cache directory
.npm

# Optional REPL history
.node_repl_history

# dotenv environment variables file
.env

# Mac OS files
.DS_Store

# Windows thumbnail cache files
Thumbs.db
Comment on lines +32 to +36
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove as we don't accept OS specific rules in template files unless they're added to the OS specific template in Global.

See macOS.gitignore for an example.
🙇

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure sir