SCons: Minor fixes/adjustments for web compilation #92026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 23, 2024
Repiteo
force-pushed
the
scons/web-fixes
branch
2 times, most recently
from
7f57e34
to
2c89838
Compare
akien-mga
reviewed
May 24, 2024
akien-mga
approved these changes
May 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a handful of tweaks with web platform builds in mind, particularly when compiling from Windows:
Warn ifOutside of PR scope.d3d12is used for non-windows platform & disable the option.[[maybe_unused]]attribute for an argument that only has guaranteed use behind a conditional.ARCOM_POSIXusesARCOMSTRfor non-verbose output.ZIPCOMSTRto non-verbose outputs.