Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind shape margin methods for PhysicsServer3D #92110

Merged
merged 1 commit into from
May 30, 2024

Conversation

mihe
Copy link
Contributor

@mihe mihe commented May 19, 2024

This binds the shape_get_margin and shape_set_margin methods found in PhysicsServer3D.

These methods aren't relevant for Godot Physics at all, but are fairly crucial when interacting with other physics engines that do make use of them (like Jolt).

There's no real reason why these shouldn't be bound when margins are exposed as part of Shape3D.

@mihe mihe requested review from a team as code owners May 19, 2024 10:31
@akien-mga akien-mga added this to the 4.3 milestone May 19, 2024
@akien-mga akien-mga merged commit 17c98a5 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@mihe mihe deleted the physics-server-margin branch May 30, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants