Improve documentation on TreeItem's cell modes #92112
Merged
+19
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
is_there_something_this_class_can't_do
branch
from
b26dd92
to
d33d2b5
Compare
AThousandShips
approved these changes
May 19, 2024
KoBeWi
force-pushed
the
is_there_something_this_class_can't_do
branch
from
d33d2b5
to
a541d45
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeItem's various cell modes has lots of quirks and hidden functionality. This PR attempts to document some of it.
My favorite Tree feature is when you assign a text to a slider, it magically becomes a dropdown.
I noticed some overall inconsistencies in the Tree/Item documentation, like descriptions referring to column, while I think it should say "cell". Also many descriptions are somewhat lacking, because most methods are specific to a single cell mode, or if used in multiple modes, they might have different effect depending on mode. I did not attempt to fix it all though.