Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for Basis * Vector3 in documentation #92117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mart3323
Copy link

@mart3323 mart3323 commented May 19, 2024

Description

This MR fixes an invalid example in the Basis documentation, fixes godotengine/godot-docs#9394

I opted to change the inputs instead of the outputs, because it seemed strange to have two identical basis vectors. Plus this allows some of the inputs to be negative

Actions performed

  • Cloned both projects, symlinked them together and ran the build both before and after the changes to confirm they show up where expected
  • Retested the GDScript example in editor to confirm the new example gives the promised result
  • ⚠️ Did not test the C# example. Though I have no reason to believe it should run any different
  • Checked the original MR to see if there were any comments about this example to be aware of
  • Ran pre-commit hooks (4 passed, rest skipped)

@mart3323 mart3323 requested a review from a team as a code owner May 19, 2024 11:57
@AThousandShips AThousandShips added bug documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 19, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for (Basis * Vector3) is incorrect
2 participants