Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f32 Gavgpool RVV implementation microkernels, tests and config changes. #6420

Merged
merged 7 commits into from
May 23, 2024

Conversation

KaustubhIMG
Copy link
Contributor

No description provided.

KaustubhIMG and others added 6 commits May 14, 2024 16:05
An rvv generator has been added to facilitate the generation of ukernels with different LMUL sizes.
This commit introduces support for generating RVV f32-gavgpool microkernels with various vector lengths in the 'generate-f32-gavgpool' script.
This commit introduces microkernels to optimize f32 gavgpool operations for different vector lengths. The files f32-gavgpool-7p7x-minmax-rvv-*.c and f32-gavgpool-7x-minmax-rvv-*.c are automatically generated by generate-f32-gavgpool.sh script.
In this commit, include test cases for the f32-gavgpool operation for variable vlenb cases. All test cases have been generated using the scripts/generate-tests.sh script.
In this commit update the f32_gavgpool_config to optimized rvv implemetation. Update the rvv.c file in amalgam as per config.
@KaustubhIMG
Copy link
Contributor Author

@fbarchard @allenkelly @bhbruce @keeranroth, If you have time, please help review this PR.

Copy link
Contributor

@fbarchard fbarchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, thanks but we plan to refactor gavgpool to use 'rdsum' so dont spend too much time on the existing avgpool/maxpool etc.

@KaustubhIMG
Copy link
Contributor Author

Do we plan to merge this PR?

@KaustubhIMG
Copy link
Contributor Author

@allenkelly can you merge this PR?

@copybara-service copybara-service bot merged commit 510b432 into google:master May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants