Add a new x8-packq microkernel that packs and per-row dynamically quantizes fp32 to qp8.
#6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
fbarchard
reviewed
May 16, 2024
| const size_t k_block_len = kr / sr; | ||
|
|
||
| for (size_t row_idx = 0; row_idx < num_rows; ++row_idx) { | ||
| float max0 = -FLT_MAX; |
There was a problem hiding this comment.
use params or initialize to the first value, like rmax
fbarchard
reviewed
May 16, 2024
| // Scale the values. | ||
| int32_t v0_s32 = (int32_t)(round(src0_0 * scale0)); | ||
|
|
||
| v0_s32 = v0_s32 + nudged_zero_point0; |
There was a problem hiding this comment.
can we make this adjustable for vnni to support +128?
fbarchard
reviewed
May 16, 2024
| const float src0_0 = *(src_ptr + k_idx + k_block_idx); | ||
|
|
||
| // Scale the values. | ||
| int32_t v0_s32 = (int32_t)(round(src0_0 * scale0)); |
fbarchard
reviewed
May 16, 2024
| v0_s32 = v0_s32 + nudged_zero_point0; | ||
| v0_s32 = fmaxf(v0_s32, INT8_MIN); | ||
| v0_s32 = fminf(v0_s32, INT8_MAX); | ||
| *((int8_t*)(dst_ptr)) = (int8_t)v0_s32; |
There was a problem hiding this comment.
can this be made to do 8 values from src0 and 8 values from src1 for i8mm?
fbarchard
reviewed
May 16, 2024
| size_t m_idx_start, // Starting index in `lhs_packed`. | ||
| const float* XNN_RESTRICT lhs, // Left-hand operator to pack. | ||
| size_t lhs_stride, // Stride in bytes between the rows of `lhs`. | ||
| void* XNN_RESTRICT lhs_packed // The quantized and packed output. |
There was a problem hiding this comment.
can lhs output be standard gemm qd8 int8 with stride and quantization params as (row sum) a different pointer?
copybara-service
bot
force-pushed
the
test_633914713
branch
6 times, most recently
from
530cd78
to
ba3ec60
Compare
…uantizes `fp32` to `qp8`. The microkernels themselves are just wrappers for the corresponding KleidiAI kernels. PiperOrigin-RevId: 633914713
copybara-service
bot
force-pushed
the
test_633914713
branch
from
ba3ec60
to
9d5e952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
x8-packqmicrokernel that packs and per-row dynamically quantizesfp32toqp8.The microkernels themselves are just wrappers for the corresponding KleidiAI kernels.