[Not for Merge] [POC] Goodput async monitoring and upload to Tensorboard POC #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobbleturk
requested changes
May 18, 2024
|
|
||
| def _query_and_upload_goodput(self): | ||
| """Queries and uploads goodput data to TensorBoard.""" | ||
| time.sleep(10) |
There was a problem hiding this comment.
Is this supposed to be goodput_upload_interval_seconds instead of hardcoded to 10? I don't see where goodput_upload_interval_seconds is used
There was a problem hiding this comment.
Ln65 can be removed, its just something I was using in the initial PoC. goodput_upload_interval_seconds (stored as self._upload_interval) is being used in Ln 68.
I apologize for the confusion, this PR is not meant to be merged it was just meant to be a PoC, I'll update the title - eventually this implementation will go into the Goodput package so that MaxText/anyone can import the module from the package and just instantiate the GoodputCalculator with monitor_goodput=True
dipannita08
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds the following:
Tested:
Note: This is a POC and this change is intended to be moved to the cloud-accelerator-doagnostics and goodput package eventually.