Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.127.0 #8668

Closed
aaemnnosttv opened this issue May 6, 2024 · 11 comments
Closed

Release 1.127.0 #8668

aaemnnosttv opened this issue May 6, 2024 · 11 comments
Labels
P0 High priority Type: Task Tasks which do not involve engineering

Comments

@aaemnnosttv
Copy link
Collaborator


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P0 High priority Type: Task Tasks which do not involve engineering labels May 6, 2024
@aaemnnosttv aaemnnosttv self-assigned this May 6, 2024
@kuasha420 kuasha420 self-assigned this May 16, 2024
@wpdarren wpdarren self-assigned this May 16, 2024
@nfmohit nfmohit self-assigned this May 16, 2024
@kelvinballoo kelvinballoo self-assigned this May 16, 2024
@tofumatt tofumatt self-assigned this May 16, 2024
@kelvinballoo
Copy link
Collaborator

QA Update ✅
Tests included but not limited to:

  • Plugin setup (activation, deactivation, deletion)
  • Disconnect & Reset Plugin
  • Module Connection & Setup
  • Ad Blocker testing
  • Help Menu
  • User Menu
  • Module Settings
  • Module Functionality

Nothing to report. LGTM!

@kuasha420
Copy link
Collaborator

Release Testing ✔️

  • Went through the release testing checklist on a new site.
  • Tested AdSense, Ads, Analytics and Tag Manager module.
  • Tested User Input and Key Metrics on Main and shared dashboard.
  • Tested Ad Blocking Recovery.

LGTM. 👍

@kuasha420 kuasha420 removed their assignment May 17, 2024
@tofumatt
Copy link
Collaborator

QA ✅

  • Went through new site setup and upgraded an existing site.
  • Tested Ads and other modules.
  • Tested Key Metrics on existing site.
  • Tested Dashboard Sharing.

All looks good to me 👍🏻

@tofumatt tofumatt removed their assignment May 17, 2024
@zutigrm zutigrm self-assigned this May 17, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

I went through our usual QA checks:

  • Tested on a site in gathering and zero data state
  • Tested on a site with live data
  • Tested Dashboard sharing
  • Tested Ad Blocking Recovery
  • Tested Enhanced Measurement
  • Tested User Input and KMW widget
  • Tested Consent Mode
  • Tested AdSense+GA4 Integration
  • Tested the Ads Module

Note: I ran some quick UI checks on the application screen for NPT and also ran through some additional testing around 2nd admin users as we've had a few bug tickets recently around 2nd admins.

@wpdarren wpdarren removed their assignment May 17, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented May 17, 2024

QA Verified ✅

  • Smoke tested
  • Tested available modules, and Ads related logic
  • Tested Key metrics
  • Tested dashboard sharing and entity dashboard
  • Tested ad blocking behaviour of Ads and AdSense
  • Performed ad hoc testing

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
image

@zutigrm zutigrm removed their assignment May 17, 2024
@hussain-t hussain-t self-assigned this May 17, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented May 17, 2024

Release Tested ✅

  • Release tested 1.127.0 thoroughly.
  • Set everything up from scratch on a live (TasteWP) site.
  • Didn't spot any unexpected console errors.
  • Verified UI in different device breakpoints.
  • Verified changes I've been involved with.
  • Used the release testing checklist to ensure everything was checked.
  • Tested Dashboard Sharing.
  • Tested GA4 + AdSense integration.
  • Tested Consent Mode.
  • Tested Ads module.
  • Tested KMW.

@nfmohit nfmohit removed their assignment May 17, 2024
@jimmymadon jimmymadon self-assigned this May 19, 2024
@hussain-t
Copy link
Collaborator

QA Verified ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Tested Consent Mode.
  • Tested Ads module.
  • Tested KMW.
  • Performed some ad-hoc testing.

LGTM 👍

@hussain-t hussain-t removed their assignment May 19, 2024
@wpdarren
Copy link
Collaborator

@zutigrm re. your question.

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?

It was decided due to the high profile of the consent mode functionality that we should include it in the entity dashboard too. I am sure Tom can confirm this is the case.

@mohitwp
Copy link
Collaborator

mohitwp commented May 20, 2024

QA Update ✅

  • Ran QA check list.
  • Verified site kit setup.
  • Verified site kit setup with analytics.
  • Verified all modules set up.
  • Verified data on site with zero and live data.
  • Verified main and entity dashboard.
  • Verified Ads module setup and migration.
  • Verified Tag manager setup and edit functionality by another admin.
  • Verified dashboard sharing and KM functionality.
  • Verified scenarios related to view only dashboard and another admin.

@jimmymadon jimmymadon removed their assignment May 20, 2024
@jimmymadon
Copy link
Collaborator

QA ✅

  • Tested all issues I was involved with.
  • Smoke tested as per the release checklist.
  • Additional testing of Ads module, Key Metrics and Dashboard Sharing.

@aaemnnosttv
Copy link
Collaborator Author

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?

@zutigrm yes, it was defined that way in #8279 👍

@aaemnnosttv aaemnnosttv removed their assignment May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Development

No branches or pull requests

10 participants