-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize Squeezebox Favourites to media player sources #117626
base: dev
Are you sure you want to change the base?
Conversation
Hey there @rajlaud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
_favs = [] | ||
for _fav in _res: | ||
_favs+=[_fav["name"]] | ||
self._sources = tuple(_favs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favorites should be exposed as media sources and not as sources. Media sources are fetched on demand, so the sync service should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balloob . That'll take changes to the python library as the browse methods don't support favorites at the moment and these libs don't seem to have been touched in quite a few years. @rajlaud, are you open to a PR on the python library if I can figure out the changes to add favorites as a category? PS, I quite liked the favourites being on the main UI of the cards as I'd seen on a couple of other (custom) components, but understand they should really be in the media browse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peteS-UK, yes, PRs are welcome to the python library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @rajlaud I'll take a look. Favorites work pretty differently to other categories I think, so from a quick glance there's going to be quite a bit of "if category=="favorites" .... else ..... Anyhow, I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can "fake" a favorites folder in the media browsing inside Home Assistant and just list the same content as you do here. That's also how we do it for some other integrations 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah c'mon @balloob , you can't tease us like that. Any pointers at which others might do it this way - seems much more sensible than burying a whole separate path in the browse.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: