Support Rest sensor XML responses that don't have an XML content type set #117715
+123
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently the rest sensor parses the returned result content as xml rather than json when the content-type is 'correctly' set by a server to include one of a set of specified xml mime types (such as text/xml).
This change extends this matching logic to also also look so see if the file extension ends in xml, or if the content starts with <?xml version="1.0" in order to support less compliant servers that are returning xml results without setting a 'correct' mime type (which I have come across).
It's unlikely this would be a breaking change for anyone as the current code falls back to parsing as json if an xml conversion fails.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: