Don't blame on disconnected AndroidTV device #117723
Conversation
home-assistant
bot
added
bugfix
cla-signed
integration: androidtv_remote
small-pr
|
Hey there @tronikos, @Drafteed, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -39,7 +39,7 @@ def is_available_updated(is_available: bool) -> None: | |||
| "Reconnected to %s at %s", entry.data[CONF_NAME], entry.data[CONF_HOST] | |||
| ) | |||
| else: | |||
| _LOGGER.warning( | |||
| _LOGGER.debug( | |||
There was a problem hiding this comment.
I had to add this because the guideline says: Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.
There was a problem hiding this comment.
The keyword here is once and it should probably be emphasized more :-) Without looking deeper into the code, this probably will probably log even when the device is already marked as unavailable in homeassistant?
Instead of changing the log level, I assume the proper fix would include marking the device as unavailable on disconnects, and only log if the device was previously available.
There was a problem hiding this comment.
Yes this is supposed to be logged once after the device disconnects. If the device manages to connect and a few seconds later it disconnects again this will be logged again.
There was a problem hiding this comment.
And if the device stays disconnected this won't be logged again per the guideline.
|
not needed as per #117722 (comment) |
Proposed change
This will reduce the "not connected" log message from warning to debug.
btw this should already be the state, since the integration is rated as platinum
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: