-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fuction composition #2954
Feature/fuction composition #2954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to contain also Virtual Proxy. Please isolate them from this PR - this should be only about Function Composition.
problems found in a file that is not in my pull request |
function-composition/README.md
Outdated
@@ -0,0 +1,113 @@ | |||
--- | |||
title: Function Composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Function Composer | |
title: Function Composition |
function-composition/README.md
Outdated
- Java | ||
--- | ||
|
||
## Name / classification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section not needed, see https://github.com/iluwatar/java-design-patterns/wiki/02.-Pattern-template
function-composition/README.md
Outdated
- Functional Programming | ||
- Composition | ||
- Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer tags from the list https://github.com/iluwatar/java-design-patterns/wiki/07.-Categories-and-Tags
function-composition/pom.xml
Outdated
<dependency> | ||
<groupId>org.projectlombok</groupId> | ||
<artifactId>lombok</artifactId> | ||
<version>1.18.20</version> <!-- Use the latest version --> | ||
<scope>provided</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, comes from the parent
Quality Gate passedIssues Measures |
Looks good! Thank you for the contribution 🎉 @all-contributors please add @Adelechka for code |
I couldn't determine any contributions to add, did you specify any contributions? @Adelechka already contributed before to code |
Function Composition pattern (#2897)
Related: #2897
Pull request description
sample java code with javadoc
test code
UML diagram
README.md file