Poseidon - update with new release #10

ImmanuelSegol · 2023-05-09T05:59:06Z

No description provided.

src/driver_client/dclient.rs

…eidon/dist

tests/integration_poseidon.rs

ImmanuelSegol · 2023-05-11T10:26:04Z

tests/integration_poseidon.rs

+            // shouldnt panic at unwrap
+            //poseidon.log_api_values();


Suggested change

// shouldnt panic at unwrap

//poseidon.log_api_values();

tests/integration_poseidon.rs

ImmanuelSegol · 2023-05-11T10:26:55Z

tests/integration_poseidon.rs

-        for _ in 0..11 {
-            let _ = poseidon.set_data(scalar.as_slice());
-        }
+    const BUFFER_SIZE: usize = 999999968; // 1GB MB // 256mb


Suggested change

const BUFFER_SIZE: usize = 999999968; // 1GB MB // 256mb

const BUFFER_SIZE: usize = 999999968; // 1GB

tests/integration_poseidon.rs

src/driver_client/dclient.rs

src/ingo_hash/poseidon_api.rs

src/ingo_hash/dma_buffer.rs

jeremyfelder · 2023-05-11T11:53:11Z

src/ingo_hash/poseidon_api.rs

@@ -31,6 +33,11 @@ pub struct PoseidonResult {
    pub layer_id: u32,
 }

+pub struct PoseidonReadResult<'a> {
+    pub expected_result: usize,


This is the size of the result and not the actual expected result?

src/ingo_hash/poseidon_api.rs

jeremyfelder · 2023-05-11T11:56:23Z

src/ingo_hash/dma_buffer.rs

Should this file be moved to the driver_client folder since it more specific to the HW integration than the primitive itself?

tests/integration_poseidon.rs

Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>

ImmanuelSegol added 3 commits May 8, 2023 17:14

refactor: update from private

dc815f6

formate

edf543a

refactor

cfe8f2a

ImmanuelSegol commented May 9, 2023

View reviewed changes

src/driver_client/dclient.rs Outdated Show resolved Hide resolved

ImmanuelSegol added 2 commits May 9, 2023 08:59

Update src/driver_client/dclient.rs

9b28d04

Merge branch 'main' into poseidon/dist

e91abe2

LeonHibnik requested a review from jeremyfelder May 10, 2023 15:13

ImmanuelSegol requested review from seemenkina and LeonHibnik May 10, 2023 15:13

ImmanuelSegol added 2 commits May 11, 2023 06:22

Merge branch 'main' of https://github.com/ingonyama-zk/blaze into pos…

52f0f2c

…eidon/dist

refactor

944361a

ImmanuelSegol commented May 11, 2023

View reviewed changes