Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to drop page button in calendar sidebar #9989

Open
exezbcz opened this issue Apr 4, 2024 · 5 comments · May be fixed by #10086
Open

Go to drop page button in calendar sidebar #9989

exezbcz opened this issue Apr 4, 2024 · 5 comments · May be fixed by #10086
Labels
A-drop-calendar issues related to drop calendar A-generative p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Apr 4, 2024

the reason is that sometimes we need the link for drop page earlier than on the day of the drop.

for this, when drop page is ready, button in the calendar sidebar will be displayed

drop page is usually ready when the code is ready - user can cycle through the variation and not just look at the previews

image

Styling

  • button is secondary

  • please follow the hover effects in the component page
    image

  • with this, could you please fix the button state for the add to calendar scheduled button that is next to it?

design in: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=394-6126&mode=design&t=81TmqAnkshCLTRdp-11

cc @vikiival
@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-generative A-drop-calendar issues related to drop calendar labels Apr 4, 2024
@daiagi daiagi self-assigned this Apr 11, 2024
@kodabot
Copy link
Collaborator

kodabot commented Apr 11, 2024

ASSIGNED - @daiagi 🔒 LOCKED -> Friday, April 12th 2024, 20:49:35 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Apr 12, 2024

ASSIGNMENT EXPIRED - @daiagi has been unassigned.

@hassnian hassnian self-assigned this Apr 16, 2024
@kodabot
Copy link
Collaborator

kodabot commented Apr 16, 2024

ASSIGNED ISSUES LIMIT REACHED - @hassnian, you have been already assigned with 5 issues: 6955,8163,8890,9921,10071,10001,9951. Finish one of them in order to get more issues assigned!

@daiagi
Copy link
Contributor

daiagi commented Apr 16, 2024

@hassnian

alias field is still missing from calendars

https://fxart-beta.kodadot.workers.dev/calendars

https://github.com/kodadot/private-workers/issues/109

@hassnian
Copy link
Contributor

hassnian commented Apr 16, 2024 •
edited

@daiagi yep, saw that I think another version of the worker might be deployed

your pr got merged and does return alias

CleanShot 2024-04-16 at 15 49 07@2x

I think poc-drops-uid is deployed

CleanShot 2024-04-16 at 15 47 51@2x

fxart main does not have that endpoint

@hassnian hassnian linked a pull request Apr 16, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-drop-calendar issues related to drop calendar A-generative p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Go to drop page button in calendar sidebar hassnian/nft-gallery
4 participants
@daiagi @hassnian @exezbcz @kodabot