Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Go to drop page button in calendar sidebar #10086

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 16, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

❗️❗️ https://github.com/kodadot/private-workers/pull/115
❗️❗️ https://github.com/kodadot/private-workers/pull/134

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-04-16 at 16 51 45

@hassnian hassnian requested a review from a team as a code owner April 16, 2024 11:52
@hassnian hassnian requested review from daiagi and Jarsen136 and removed request for a team April 16, 2024 11:52
@kodabot
Copy link
Collaborator

kodabot commented Apr 16, 2024

WARNING @hassnian PR for issue #9989 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9989

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1e7012c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663cc486dcab350007367e7c
😎 Deploy Preview https://deploy-preview-10086--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian
Copy link
Contributor Author

with this, could you please fix the button state for the add to calendar scheduled button that is next to it?

@exezbcz is this an issue with the variant itself? iirc I've done this change before

@hassnian hassnian requested a review from daiagi April 17, 2024 06:50
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

components/drops/calendar/DropPreviewModal.vue Outdated Show resolved Hide resolved
@prury
Copy link
Member

prury commented Apr 22, 2024

waiting for pending commit suggestion and workers PR to be merged so i can test

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 25, 2024
@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Apr 29, 2024
Copy link

codeclimate bot commented May 9, 2024

Code Climate has analyzed commit 1e7012c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented May 10, 2024

i think here we are waiting for this? https://github.com/kodadot/private-workers/pull/134#issuecomment-2100100614
side note: calendar not loading in this PR

@daiagi
Copy link
Contributor

daiagi commented May 10, 2024

image

the chain query param causes nothing to return from worker
nothing as in not even empty json. just nothing

meanwhile. works in canary

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 10, 2024
@hassnian
Copy link
Contributor Author

nothing as in not even empty json. just nothing

it's returning an empty array

CleanShot 2024-05-11 at 10 38 14@2x

the worker is working as intended , it's filtering using the chain but all calendars need to be updated to have chain set to ahp

https://github.com/kodadot/private-workers/pull/134#issuecomment-2100100614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to drop page button in calendar sidebar
5 participants