Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie popup styling #10212

Closed
exezbcz opened this issue May 4, 2024 · 2 comments · Fixed by #10238
Closed

cookie popup styling #10212

exezbcz opened this issue May 4, 2024 · 2 comments · Fixed by #10238
Labels
A-modal issues related to modals analytics p2 core functionality, or is affecting 60% of app

Comments

@exezbcz
Copy link
Member

exezbcz commented May 4, 2024

since this got recently merged, lets sync it with our design change that was few weeks ago

image

Data collecting

google analytics are off by default?
image

styling

image

Accept should be the "main" button

link to figma: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1287-18959&mode=design&t=wIR4vUyhVh1KHnUu-11
@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app analytics A-modal issues related to modals labels May 4, 2024
@hassnian
Copy link
Contributor

hassnian commented May 4, 2024 •
edited

fix: cookie banner styles are applying to regular buttons

CleanShot 2024-05-04 at 13 50 31

@exezbcz
Copy link
Member Author

exezbcz commented May 4, 2024

these buttons can be button secondary outline rounded
image

image

@roiLeo roiLeo mentioned this issue May 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-modal issues related to modals analytics p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔧 cookie banner btn design roiLeo/nft-gallery
2 participants
@hassnian @exezbcz