Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 cookie banner btn design #10238

Merged
merged 7 commits into from May 9, 2024
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 6, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

(please remove design and QA checks below if not needed)

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Screenshot 2024-05-06 at 09-55-38 KodaDot - NFT Market Explorer
Screenshot 2024-05-06 at 09-57-06 KodaDot - NFT Market Explorer
Screenshot 2024-05-06 at 15-40-16 KodaDot - NFT Market Explorer

Note

Capture d’écran 2024-05-06 à 10 09 18 AM

might come from recent NeoButton changes (ref #10210)

@roiLeo roiLeo requested a review from a team as a code owner May 6, 2024 08:10
@roiLeo roiLeo requested review from vikiival and hassnian and removed request for a team May 6, 2024 08:10
Copy link

netlify bot commented May 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0c33635
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663a2f3a7bab560008518f8b
😎 Deploy Preview https://deploy-preview-10238--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented May 6, 2024

dark mode:

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 6, 2024
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels May 6, 2024
@exezbcz
Copy link
Member

exezbcz commented May 6, 2024

hello!

could you please match the style to the cookie banner we use on production

image

also the text of the paragraph is currently arial

@exezbcz
Copy link
Member

exezbcz commented May 6, 2024

Note

Capture d’écran 2024-05-06 à 10 09 18 AM might come from recent `NeoButton` changes (ref #10210)

imo it came from here no?
image

@vikiival vikiival requested a review from Jarsen136 May 6, 2024 20:12
@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 6, 2024
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 0c33635 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@prury prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 9, 2024
@prury prury added this pull request to the merge queue May 9, 2024
Merged via the queue into kodadot:main with commit eba2a44 May 9, 2024
19 checks passed
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookie popup styling
5 participants