refactor: adjust hash for metadata #10148

preschian · 2024-04-25T19:26:49Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix

Context

Related: https://github.com/kodadot/ops-internal/issues/1659
Need workers deployment: https://github.com/kodadot/private-workers/pull/165

Did your issue had any of the "$" label on it?

My DOT address: Payout

netlify · 2024-04-25T19:27:12Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`4739d67`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/66548c0fb058db00083f4551
😎 Deploy Preview	https://deploy-preview-10148--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hassnian

PaidMint.vue missing close emit
HolderOfGenerative.vue also needs to be updated like PaidGenerative.vue did

prury · 2024-05-22T20:08:41Z

what about this one?

preschian · 2024-05-23T04:26:29Z

Oh, sorry, I missed the notification about this. will update

…rt.ts * refactor: rename updateMetadata to submitMetadata in useGenerativeDropMint.ts * fix: remove hash property from object in useDropMassMint.ts

cloudflare-pages · 2024-05-23T04:44:13Z

Deploying koda-art-prod with Cloudflare Pages

Latest commit:	`4739d67`
Status:	✅ Deploy successful!
Preview URL:	https://43a947fd.kodaart-production.pages.dev
Branch Preview URL:	https://fix-reload-on-drops.kodaart-production.pages.dev

View logs

…-on-drops

preschian · 2024-05-23T05:20:00Z

PaidMint.vue missing close emit

HolderOfGenerative.vue also needs to be updated like PaidGenerative.vue did

Updated description: I slightly changed the PR.

I reverted the PaidMint.vue; it turns out I got a random reload on a random page, not just a drops page.
CollectionDropModalPaidMint on HolderOfGenerative.vue seems like already the same with PaidGenerative.vue

* feat(locales/en.json): change 'createNewVariation' string to 'Preview Iteration'

components/collection/drop/PaidGenerative.vue

…intModal method

Jarsen136 · 2024-05-23T11:49:25Z

This PR removes the hash while minting the drop. It means the preview image on the drop page would not be the same as the item he minted finally. There should be something else needs to be implemented on the image preview component. Correct me if I'm wrong.

preschian · 2024-05-23T23:19:15Z

This PR removes the hash while minting the drop. It means the preview image on the drop page would not be the same as the item he minted finally. There should be something else needs to be implemented on the image preview component. Correct me if I'm wrong.

Correct 👍🏻
I think we can simplify the "Mint Drop" modal. It would reduce some of the code, and the user would not need to wait for the preview to render (especially for massmint).

I am planning to do that in a separate branch (branching from this: #10336)

Jarsen136 · 2024-05-24T07:31:02Z

This PR removes the hash while minting the drop. It means the preview image on the drop page would not be the same as the item he minted finally. There should be something else needs to be implemented on the image preview component. Correct me if I'm wrong.

Correct 👍🏻 I think we can simplify the "Mint Drop" modal. It would reduce some of the code, and the user would not need to wait for the preview to render (especially for massmint).

I am planning to do that in a separate branch (branching from this: #10336)

Great! Let's leave it to separate PR.

prury · 2024-05-24T14:12:43Z

i understand that we still got to adjust the modal flow after that change, but the nft i minted using this PR has no image:

https://deploy-preview-10148--koda-canary.netlify.app/ahk/gallery/379-2405285173

Screencast.from.2024-05-24.11-02-42.webm

EDIT: never mind, problem comes from fxart

locales/en.json

sonarcloud · 2024-05-27T13:35:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codeclimate · 2024-05-27T13:35:54Z

Code Climate has analyzed commit 4739d67 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

View more on Code Climate.

prury · 2024-05-27T14:06:34Z

i don't think its working properly @preschian

Screencast.from.2024-05-27.11-03-20.webm

its generating images without sn or proper variation:
(the one that worked is from canary)

preschian · 2024-05-27T14:24:14Z

its generating images without sn or proper variation:
(the one that worked is from canary)

Need to wait it for a moment. Currently, the blockchain itself is unable to mint and set metadata at the same time. Currently, we solve it by updating the metadata (image preview, name, sn, animationUrl, etc.) synchronously. refer: https://github.com/kodadot/private-workers/issues/87#issuecomment-2006716343

prury · 2024-05-27T14:32:04Z

its generating images without sn or proper variation:
(the one that worked is from canary)

Need to wait it for a moment. Currently, the blockchain itself is unable to mint and set metadata at the same time. Currently, we solve it by updating the metadata (image preview, name, sn, animationUrl, etc.) synchronously.

oh, cool, ok!

fix: reload on drops

bb4ca31

preschian marked this pull request as ready for review April 25, 2024 19:30

preschian requested a review from a team as a code owner April 25, 2024 19:30

preschian requested review from Jarsen136, hassnian and prury and removed request for a team April 25, 2024 19:30

prury added the waiting-for-review label Apr 26, 2024

hassnian reviewed Apr 29, 2024

View reviewed changes

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 29, 2024

hassnian mentioned this pull request May 22, 2024

fix: It is still possible to mint two identic images #10334

Open

7 tasks

preschian added 2 commits May 23, 2024 11:31

revert: paidmint

6440a07

* refactor: remove hash parameter from updateMetadata function in fxa…

4e6ce0c

…rt.ts * refactor: rename updateMetadata to submitMetadata in useGenerativeDropMint.ts * fix: remove hash property from object in useDropMassMint.ts

Merge branch 'main' of github.com:kodadot/nft-gallery into fix/reload…

d7ad7ab

…-on-drops

preschian changed the title ~~fix: reload on drops~~ refactor: adjust hash for metadata May 23, 2024

* fix(locales/en.json): correct spacing in 'chooseWallet' string

07c04da

* feat(locales/en.json): change 'createNewVariation' string to 'Preview Iteration'

hassnian reviewed May 23, 2024

View reviewed changes

components/collection/drop/PaidGenerative.vue Show resolved Hide resolved

* feat(PaidGenerative.vue): add clearMassMint function call in closeM…

b149129

…intModal method

Jarsen136 approved these changes May 24, 2024

View reviewed changes

preschian mentioned this pull request May 24, 2024

refactor: cleanup preview items on drops page #10344

Open

8 tasks

hassnian approved these changes May 26, 2024

View reviewed changes

Merge branch 'main' into fix/reload-on-drops

c8eb1c1

prury reviewed May 27, 2024

View reviewed changes

locales/en.json Outdated Show resolved Hide resolved

prury added 2 commits May 27, 2024 10:19

Merge branch 'main' into fix/reload-on-drops

9c23d21

replace iteration with variations

4739d67

prury removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning waiting-for-review labels May 27, 2024

prury added this pull request to the merge queue May 27, 2024

Merged via the queue into main with commit 88704d5 May 27, 2024
19 of 20 checks passed

prury deleted the fix/reload-on-drops branch May 27, 2024 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: adjust hash for metadata #10148

refactor: adjust hash for metadata #10148

preschian commented Apr 25, 2024 •

edited

netlify bot commented Apr 25, 2024 •

edited

hassnian left a comment •

edited

prury commented May 22, 2024

preschian commented May 23, 2024

cloudflare-pages bot commented May 23, 2024 •

edited

preschian commented May 23, 2024

Jarsen136 commented May 23, 2024

preschian commented May 23, 2024 •

edited

Jarsen136 commented May 24, 2024

prury commented May 24, 2024 •

edited

sonarcloud bot commented May 27, 2024

codeclimate bot commented May 27, 2024

prury commented May 27, 2024 •

edited

preschian commented May 27, 2024

prury commented May 27, 2024

refactor: adjust hash for metadata #10148

refactor: adjust hash for metadata #10148

Conversation

preschian commented Apr 25, 2024 • edited

PR Type

Context

Did your issue had any of the "$" label on it?

netlify bot commented Apr 25, 2024 • edited

✅ Deploy Preview for koda-canary ready!

hassnian left a comment • edited

Choose a reason for hiding this comment

prury commented May 22, 2024

preschian commented May 23, 2024

cloudflare-pages bot commented May 23, 2024 • edited

Deploying koda-art-prod with Cloudflare Pages

preschian commented May 23, 2024

Jarsen136 commented May 23, 2024

preschian commented May 23, 2024 • edited

Jarsen136 commented May 24, 2024

prury commented May 24, 2024 • edited

sonarcloud bot commented May 27, 2024

Quality Gate passed

codeclimate bot commented May 27, 2024

prury commented May 27, 2024 • edited

preschian commented May 27, 2024

prury commented May 27, 2024

preschian commented Apr 25, 2024 •

edited

netlify bot commented Apr 25, 2024 •

edited

hassnian left a comment •

edited

cloudflare-pages bot commented May 23, 2024 •

edited

preschian commented May 23, 2024 •

edited

prury commented May 24, 2024 •

edited

prury commented May 27, 2024 •

edited