Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintanence + DX] - delete old queries and POC gql-tada #10197

Merged
merged 48 commits into from May 16, 2024
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 3, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature
  • Refactoring / Maintenance / Remove dead code

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

@daiagi daiagi requested a review from a team as a code owner May 3, 2024 08:06
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team May 3, 2024 08:06
Copy link

netlify bot commented May 3, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4dffbc6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6645fe5562e2a00008d962fb
😎 Deploy Preview https://deploy-preview-10197--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented May 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@0no-co/graphqlsp@1.12.2 Transitive: environment, network +2 1.92 MB jdecroock

View full report↗︎

@daiagi
Copy link
Contributor Author

daiagi commented May 13, 2024

@preschian Thank you

All done

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

queries/fragments/typed/nftSubsquid.ts Outdated Show resolved Hide resolved
queries/fragments/typed/nft.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

Please @daiagi, @Jarsen136 and @prury go through app and make sure that every page and chain work as intended :)

@daiagi
Copy link
Contributor Author

daiagi commented May 13, 2024

@vikiival

Prob delete as it is same as nft.ts
add updatedAt to be able to remove

done

@daiagi
Copy link
Contributor Author

daiagi commented May 13, 2024

i have scanned throuh

  • home page (all chains)
  • explore collections and items (all chains)
  • my profile page
  • drops home page
  • single ahk drop page
  • create pages
  • single nfty page (all chains)
  • single collection page (all chains)

so far 0 graphql issues detected

@vikiival
Copy link
Member

How about trasactions like create collection,

list/buy NFT ?

@daiagi
Copy link
Contributor Author

daiagi commented May 13, 2024

How about trasactions like create collection,
list/buy NFT ?

i did buy and list 1 ahp nft

@Jarsen136
Copy link
Contributor

I went through the website and did not find anything abnormal.

@prury
Copy link
Member

prury commented May 13, 2024

How about trasactions like create collection,
list/buy NFT ?

i did buy and list 1 ahp nft

i will perform transaction tests as well trough the day

@daiagi daiagi changed the title [Maintanence + DX] - delete old queries and POC gql-data [Maintanence + DX] - delete old queries and POC gql-tada May 13, 2024
@prury
Copy link
Member

prury commented May 13, 2024

NFT Transfer ✅
Change Price ✅
Collection Creation ✅
NFT Creation(List, copies) ✅
Mass buy ✅
Mass list ✅
Drop Mint ✅

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 13, 2024
@prury
Copy link
Member

prury commented May 13, 2024

failing test can be ignored

Copy link

cloudflare-pages bot commented May 16, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4dffbc6
Status: ✅  Deploy successful!
Preview URL: https://08b2fe83.kodaart-production.pages.dev
Branch Preview URL: https://poc-gql-tada.kodaart-production.pages.dev

View logs

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit 4dffbc6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented May 16, 2024

i've resolved conversations, merging now

@prury prury added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 751fb0b May 16, 2024
20 checks passed
@prury prury deleted the POC-gql-tada branch May 16, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DX] Generate auto types from graphql and rest api
5 participants