Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When transaction failed, opening modal resets the state weirdly #10252

Merged
merged 5 commits into from May 13, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented May 7, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-05-07.at.11.21.10.mp4

@hassnian hassnian requested a review from a team as a code owner May 7, 2024 06:38
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team May 7, 2024 06:38
Copy link

netlify bot commented May 7, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2ea1aca
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663b14ad994e5e0008bd4131
😎 Deploy Preview https://deploy-preview-10252--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 7, 2024
Copy link

codeclimate bot commented May 8, 2024

Code Climate has analyzed commit 2ea1aca and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

hassnian commented May 8, 2024

after last change

CleanShot.2024-05-08.at.10.53.44.mp4

@prury prury requested a review from preschian May 10, 2024 20:05
@prury prury added this pull request to the merge queue May 13, 2024
Merged via the queue into kodadot:main with commit b629c7f May 13, 2024
19 checks passed
@prury prury deleted the issue-10224 branch May 13, 2024 11:34
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When transaction failed, opening modal resets the state weirdly
4 participants