Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7879 Disable change price from explorer #7923

Closed
wants to merge 2 commits into from

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 2, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • [] My fix has changed UI

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner November 2, 2023 04:17
@prachi00 prachi00 requested review from preschian and floyd-li and removed request for a team November 2, 2023 04:17
@kodabot
Copy link
Collaborator

kodabot commented Nov 2, 2023

SUCCESS @prachi00 PR for issue #7879 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6b853a1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65447131c4ff9500086f18fe
😎 Deploy Preview https://deploy-preview-7923--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 2, 2023

AI-Generated Summary: This pull request titled "#7879 Disable change price from explorer" is a code change involving modification to three Vue.js components within an application. These changes pertain to adjustments related to item listing and pricing within an e-commerce context.

Summary of changes:

  1. Items.vue has been modified to hide the relist option. This could prevent users from relisting items on the grid.
  2. ItemsGrid.vue has had a hideRelist prop added which might be used to conditionally hide the relist option at a more granular level, potentially on a per-item basis.
  3. Lastly, ItemsGridImage.vue has been updated to respect the hideRelist prop such that if an user is the owner of a list item and hideRelist is false, they are provided with the option to relist their item.

The overall intent seems to be to provide a way to conditionally hide the ability for item owners to relist their items through the application user interface. This might be useful for managing item relisting in different contexts or for different types of items or users.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 2, 2023
@prury
Copy link
Member

prury commented Nov 2, 2023

still occurs on Assethubs:
image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 2, 2023
Copy link

codeclimate bot commented Nov 3, 2023

Code Climate has analyzed commit 6b853a1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@prachi00
Copy link
Member Author

prachi00 commented Nov 3, 2023

still occurs on Assethubs: image

is it still there for you? I cant see change price anymore

@prury
Copy link
Member

prury commented Nov 3, 2023

still occurs on Assethubs: image

is it still there for you? I cant see change price anymore

yeah @prachi00, still the same:

image

@prachi00
Copy link
Member Author

prachi00 commented Nov 6, 2023

still occurs on Assethubs: image

is it still there for you? I cant see change price anymore

yeah @prachi00, still the same:

image

weird, I am going to close this one since I cant test it properly

@prachi00 prachi00 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable change price from explorer
3 participants