Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by nft attributes in collection #9798

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iMac7
Copy link
Contributor

@iMac7 iMac7 commented Mar 17, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screenshot_20240317_170643

More of a draft because I haven't understood some stuff about the issue.

(my comment in issue)

  * has a price floor in range <0.1, 0.1-0.3, 0.3-1, 1-3, 3-10, >10 (make as drop down probably) // maybe range slider as done in gallery?

I don't understand what price floor is. volume? (volume_gt: 0)

@iMac7 iMac7 requested a review from a team as a code owner March 17, 2024 14:24
@iMac7 iMac7 requested review from preschian and Jarsen136 and removed request for a team March 17, 2024 14:24
@kodabot
Copy link
Collaborator

kodabot commented Mar 17, 2024

SUCCESS @iMac7 PR for issue #1023 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f2d5932
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65f6fd142c3c370008e59bf9
😎 Deploy Preview https://deploy-preview-9798--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Mar 17, 2024

Code Climate has analyzed commit f2d5932 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 17, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Mar 18, 2024

I think solution needs a better design, maybe @exezbcz can cook something if he has time
@iMac7 the issue describes more than one filter, and you are solving only a part of it(no problem with this at all), but then you have to change the Closes: #Issue number, to Related: #issue number

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 18, 2024
@iMac7
Copy link
Contributor Author

iMac7 commented Mar 18, 2024

I think solution needs a better design, maybe @exezbcz can cook something if he has time @iMac7 the issue describes more than one filter, and you are solving only a part of it(no problem with this at all), but then you have to change the Closes: #Issue number, to Related: #issue number

Yes it doesn't solve the entire issue. I have a question which I posted on the issue and I'll make changes as soon as that is clarified. I'll try making the design better as well :)

@iMac7 iMac7 marked this pull request as draft March 24, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show only collection which has NFT with various properties/attributes
3 participants