Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable change price from explorer #9880

Closed
wants to merge 1 commit into from

Conversation

iMac7
Copy link
Contributor

@iMac7 iMac7 commented Mar 26, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot_20240326_101532

can't capture cursor on screenshot 😆 it's on the left Christmas City card

@iMac7 iMac7 requested a review from a team as a code owner March 26, 2024 07:17
@iMac7 iMac7 requested review from preschian and Jarsen136 and removed request for a team March 26, 2024 07:17
@kodabot
Copy link
Collaborator

kodabot commented Mar 26, 2024

SUCCESS @iMac7 PR for issue #7879 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2df3f92
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6602769eaaa7760008cd770f
😎 Deploy Preview https://deploy-preview-9880--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Mar 26, 2024

Code Climate has analyzed commit 2df3f92 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Mar 26, 2024

hey, it's still enabled on RMRK2/1, can you also remove it there? thank you

@prury prury added S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-stale pull request which haven't seen any changes for last 3 days, with this labels will be close in 7days labels Mar 26, 2024
@iMac7 iMac7 marked this pull request as draft March 30, 2024 09:04
@iMac7
Copy link
Contributor Author

iMac7 commented Mar 30, 2024

hey, it's still enabled on RMRK2/1, can you also remove it there? thank you

@prury failed attempt at buying nft to test on rmrk.
transaction went through but nft didn't arrive - wallet
idk where I put the transaction hash but the only events from this wallet are transferring in some ksm and buying an nft with autoteleport.

converting to draft until I resolve this

@prury prury closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-stale pull request which haven't seen any changes for last 3 days, with this labels will be close in 7days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable change price from explorer
3 participants