Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to options.php - missing ! on line 940 causes custom field usage ... #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-nom-ali
Copy link

...to fail.

@pospi
Copy link

pospi commented Sep 6, 2013

Please merge this ASAP - I was just about to make the same pull request as it does break the ability to extend the framework with classes defined outside of the main 'fields' directory.

This also seems to be the same request as #148

@noameppel
Copy link

I don't believe NHP Theme Options Framework is still being developed. Redux Framework is a fork which is under active development: https://github.com/ghost1227/Redux-Framework

@a-nom-ali
Copy link
Author

As far as I know I've already done a pull request on this change?

On Fri, Sep 6, 2013 at 3:02 AM, pospi notifications@github.com wrote:

Please merge this ASAP - I was just about to make the same pull request as
it does break the ability to extend the framework with classes defined
outside of the main 'fields' directory.


Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-23912654
.

@pospi
Copy link

pospi commented Sep 16, 2013

Indeed! Looks like it was fixed in v1.0.1, sorry about that. Maybe the version we were working with was forked quite long ago. Thanks for getting back to us (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants