Skip to content

Commit

Permalink
Removed Lombok @getter(onMethod = @__(@OverRide))
Browse files Browse the repository at this point in the history
- Was causing JavaDoc to silently fail
  • Loading branch information
lessthanoptimal committed Dec 22, 2020
1 parent 1379c51 commit e72bdf7
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ task alljavadoc(type: Javadoc, group: "Documentation") {

configure(options) {
failOnError = false
title = "BoofCV JavaDoc ($project.version)"
title = "BoofCV ($project.version)"
links = [ 'http://docs.oracle.com/javase/8/docs/api/',
'http://ejml.org/javadoc/',
'http://georegression.org/javadoc/',
Expand Down
2 changes: 1 addition & 1 deletion change.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Change Log
Date Format: year/month/day

---------------------------------------------
Date : 2020
Date : 2020/Dec/21
Version : 0.37

- Build
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import georegression.struct.affine.Affine2D_F64;
import georegression.struct.point.Point2D_F64;
import georegression.transform.affine.AffinePointOps_F64;
import lombok.Getter;

/**
* Applies an affine transform to a 2D point.
Expand All @@ -32,7 +31,6 @@
*/
public class PointTransformAffine_F64 implements Point2Transform2Model_F64<Affine2D_F64> {

@Getter(onMethod = @__(@Override))
protected final Affine2D_F64 model = new Affine2D_F64();

public PointTransformAffine_F64( Affine2D_F64 affine ) {
Expand All @@ -53,6 +51,10 @@ public PointTransformAffine_F64() {}
this.model.setTo(model);
}

@Override public Affine2D_F64 getModel() {
return model;
}

@Override public Affine2D_F64 newInstanceModel() {
return new Affine2D_F64();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import georegression.struct.homography.UtilHomography_F64;
import georegression.struct.point.Point2D_F64;
import georegression.transform.homography.HomographyPointOps_F64;
import lombok.Getter;
import org.ejml.data.DMatrix;
import org.ejml.data.DMatrixRMaj;

Expand All @@ -34,7 +33,6 @@
*/
public class PointTransformHomography_F64 implements Point2Transform2Model_F64<Homography2D_F64> {

@Getter(onMethod = @__(@Override))
final Homography2D_F64 model = new Homography2D_F64();

public PointTransformHomography_F64() {}
Expand All @@ -59,6 +57,10 @@ public void set( DMatrix transform ) {
model.set(o);
}

@Override public Homography2D_F64 getModel() {
return model;
}

@Override public Homography2D_F64 newInstanceModel() {
return new Homography2D_F64();
}
Expand Down
2 changes: 2 additions & 0 deletions misc/release_check_list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

--- Fresh Checkout ---

WARNING: Android will currently cause JavaDoc to fail. Either debug this or comment out in settings.gradle.

VERSION=v0.XX
git clone -b SNAPSHOT --recursive git@github.com:lessthanoptimal/BoofCV.git boofcv
cd boofcv;./gradlew autogenerate;rm -rf .git;cd ..;zip -r boofcv-$VERSION-src.zip boofcv
Expand Down

0 comments on commit e72bdf7

Please sign in to comment.