Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(electron): options to disable file watcher #11315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented May 16, 2024

Rationale:

  • Some Sync Disks wipe out files that are not visited frequently
  • Some FS doesn't have file change notifications(NFS, external driver based FS)
  • Encryption Disks might lock files and issue a file change event

Drawbacks:

  • When the file is changed outside, "Content conflicting" warning will be shown only after user edits it in Logseq
  • "Refresh" should be used if something is changed outside
  • Logseq Sync is not useable with this option turned off

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant