-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setup for rn-windows #1158
base: master
Are you sure you want to change the base?
Conversation
Hmmm. I can't run anything locally right now, since I don't have a windows machine and i am a bit hesitant about touching anything in core. I'll run the CI to see if anything breaks with this in our current setup in the meantime and maybe we can update the examples to include windows so we can test these properly. @matinzd what do you think? |
Good question, I also hesitated to make any changes to the core in an inappropriate way. To keep this as transparent and clear as possible, I will add CI to see if anything breaks on Windows. I believe this is a critical bug, as without it, lottie-react-native 6.x.x doesn't work on Windows. |
A basic summary of what I did in this last change: the dependency on |
Left one change that i think is important. The rest looks good. I'll let the CI run and once all the stuff is resolved, we can merge. One question though, mostly out of curiosity, does the linking for |
The CI failed again. Looks like it is missing an SDK: |
I fixed the absence of the SDK and added an extra step to check which SDKs are installed👍. |
Co-authored-by: Parsa Nasirimehr <40071952+TheRogue76@users.noreply.github.com>
The Workflow file is being reported as invalid. I believe you have a typo on Line 33: |
Hi. |
Description
I added only a few basic configurations so that the autolink in react-native-windows recognizes the library. I followed the recommendations from https://microsoft.github.io/react-native-windows/docs/native-modules-setup.
Steps To Reproduce
Follow these steps at https://microsoft.github.io/react-native-windows/docs/getting-started and create a React Native app. Then, run
npx react-native autolink-windows
. You'll notice that the file LottieReactNative.vsxproj is not present in the solutions list.Expected Results
The LottieReactNative.vcxproj file should appear in the list of solutions.