Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radicle: init #5409

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lorenzleutgeb
Copy link

Description

Radicle is a distributed code forge based on Git. I recently overhauled the package in Nixpkgs and have been using programs.radicle (for basic configuration of Radicle) and services.radicle (for managing radicle-node and radicle-http as systemd user services) for a few weeks without problems (links to my personal repo).

I could need some help with the tests. home-files/.radicle seems to be missing and I don't understand why:

$ ls -la /nix/store/afg8b60b5a79ziw03yfiwdcmmnis58l3-nmt-report-radicle-basic-configuration/tested/home-files
dr-xr-xr-x - root 1970-01-01 02:00 .cache
dr-xr-xr-x - root 1970-01-01 02:00 .config
dr-xr-xr-x - root 1970-01-01 02:00 asserts

Checklist

  • Change is backwards compatible. (Trivially, since there is no earlier version.)
  • Code formatted with ./format.
  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.
  • Test cases updated/added. See example.
  • Commit messages are formatted.
  • Added myself as module maintainer.

@ju1m
Copy link

ju1m commented May 21, 2024

Thanks a lot @lorenzleutgeb for the nixpkgs PR and this draft!
Here's the changes I had to do to make progress https://github.com/ju1m/home-manager/commits/radicle/
Alas, with nixos-23.11's rustc, building radicle-node (after cherry-picking the nixpkgs PR) fails:

radicle-node> Found a `cargo::key=value` build directive which is reserved for future use.                                                                                                                                                                     
radicle-node> Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.                                                                                                                                   
radicle-node> See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

so I'll have to update to the upcoming nixos-24.05 before trying this further more.

@lorenzleutgeb
Copy link
Author

Hey! Thanks for your help.

If you like, you can also try the Flake at https://github.com/lorenzleutgeb/heartwood in the meantime.

I also have things coming at https://github.com/lorenzleutgeb/radicle-nix, including more changes to the modules in this PR...

What I don't understand is why you reverted to http://github.com/lorenzleutgeb/nur ? The formatting in these files does not conform to home-manager's requirements.

@ju1m
Copy link

ju1m commented May 21, 2024

If you like, you can also try the Flake at https://github.com/lorenzleutgeb/heartwood in the meantime.

Thanks @lorenzleutgeb

I also have things coming at https://github.com/lorenzleutgeb/radicle-nix, including more changes to the modules in this PR...

Nice to also have a NixOS service, do you plan to open a PR to upstream it?
Just in passing, something that should be checked is whether LoadCredential= can load a path from LoadCredentialEncrypted=, otherwise we may have to add some logic to support LoadCredentialEncrypted=.

What I don't understand is why you reverted to http://github.com/lorenzleutgeb/nur ? The formatting in these files does not conform to home-manager's requirements.

Well it's only after seeing that there were differences between this PR and the NUR version, and that the NUR contained two fixes (services.radicle.httpd.environnement.default's cfg.node.enable => {} and {RestartDelayMaxSec => RestartMaxDelaySec}) while looking more advanced on socket activation, that I rebased my changes on the NUR version. The formatting can always be fixed later on.

Nice to see you're actively working on this, happy to review your changes on this PR whenever you're ready to push them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants