Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary uses of nvim_win_call #127

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

willothy
Copy link
Collaborator

@willothy willothy commented Aug 24, 2023

fix: remove unnecessary uses of nvim_win_call

(moving immediate autoresize to another PR as it needs test changes)

closes #122

@willothy willothy changed the title fix: autoresize immediately on mode change fix: remove unnecessary uses of nvim_win_call Aug 24, 2023
@cryptomilk
Copy link
Collaborator

Thanks for your contribution!

Remember: Untested code is broken code :-)

@willothy
Copy link
Collaborator Author

Remember: Untested code is broken code :-)

Usually I'd agree, but this is a tiny fix that pretty much just removes a line that was previously broken, so not sure what test I'd add for this. Let me know if you have any ideas.

@cryptomilk
Copy link
Collaborator

Obvoiously our test didn't catch this bug someone noticed it an opened #122. So what are the steps the of the person running into this?

@willothy
Copy link
Collaborator Author

Obvoiously our test didn't catch this bug someone noticed it an opened #122. So what are the steps the of the person running into this?

Ah, gotcha, I see! I'll add a test for maximize overall.

@cryptomilk
Copy link
Collaborator

Thanks! :-)

@willothy
Copy link
Collaborator Author

willothy commented Sep 5, 2023

May not have time to get to that right away as I'm a bit busy this week, maybe this PR should be merged since it's a hotfix and definitely works, and I'll add the test in a followup PR in a few days? Up to you though :)

@willothy
Copy link
Collaborator Author

willothy commented Sep 6, 2023

Added tests @cryptomilk

@cryptomilk
Copy link
Collaborator

Awesome thanks!

@cryptomilk cryptomilk merged commit 229eb73 into nvim-focus:master Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximize seems to be broken
2 participants