Add maximize() method. Fixes #4181. #4488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there doesn't seem to be an easy way to predict the maximized window's content size across platforms and renderers (you can get it with the window decoration included, but not easily without), the animation thread is blocked from starting until the window has actually maximized, and the correct content size has been established. This means that width and height have their correct values in setup().
If the user picks a renderer that doesn't support this, the sketch will start normally after a 2500ms delay, and they'll see an error message, naming their renderer as the culprit. The code for the JavaFX renderer is hacky; there just doesn't seem to be a better way.
Fixes #4181.