Make color, fill, stroke et al. thread-safe: #3077 #4784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4774 improved.
color
should be entirely thread-safe; it should now also be impossible forfill
andstroke
(or background or whatever) to pass values between each other; i.e.fill(#009700)
andstroke(#000056)
running at once shouldn't lead to a fill color of0xff000056
, which was previously possible. In theory I think that running two fill() commands with different values at once might lead to thefillR
etc. values being made from a mixture of the two colors, but I haven't been able to demonstrate this and I don't want to add any performance hit by making all fill methods synchronize onfillArray
since using fill() in two threads is a highly unlikely situation.Fixes #3077.