Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make color, fill, stroke et al. thread-safe: #3077 #4784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GKFX
Copy link
Contributor

@GKFX GKFX commented Dec 20, 2016

#4774 improved. color should be entirely thread-safe; it should now also be impossible for fill and stroke (or background or whatever) to pass values between each other; i.e. fill(#009700) and stroke(#000056) running at once shouldn't lead to a fill color of 0xff000056, which was previously possible. In theory I think that running two fill() commands with different values at once might lead to the fillR etc. values being made from a mixture of the two colors, but I haven't been able to demonstrate this and I don't want to add any performance hit by making all fill methods synchronize on fillArray since using fill() in two threads is a highly unlikely situation.
Fixes #3077.

calcEtc color variables deleted; colorCalc now fills a float[4] array
and returns int.
@GKFX GKFX closed this Dec 21, 2016
@GKFX GKFX reopened this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant