Move tests #125256
Open
Move tests #125256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Thanks! |
bors
added
S-waiting-on-bors
workingjubilee
requested changes
May 18, 2024
| @@ -3618,6 +3615,7 @@ ui/recursion/issue-83150.rs | |||
| ui/recursion/issue-86784.rs | |||
| ui/recursion/issue-95134.rs | |||
| ui/recursion_limit/issue-105700.rs | |||
| ui/recursion_limit/issue-37311-type-length-limit/issue-37311.rs | |||
There was a problem hiding this comment.
Would you please instead rename this and the associated .stderr files to
- tests/ui/recursion_limit/type-length-limit-issue-37311.rs
- tests/ui/recursion_limit/type-length-limit-issue-37311.stderr
- tests/ui/recursion_limit/type-length-limit-issue-37311.polonius.stderr
My reasoning is that there doesn't seem to be much merit in nesting these inside a folder that has the same name, and that this would allow eliminating these entries from this list.
Comment on lines
+3851
to
+3852
| ui/static/issue-3668-non-constant-value-in-constant/issue-3668-2.rs | ||
| ui/static/issue-3668-non-constant-value-in-constant/issue-3668.rs |
There was a problem hiding this comment.
same request but
- tests/ui/static/non-constant-value-in-constant-issue-3668.rs
- tests/ui/static/non-constant-value-in-constant-issue-3668-2.rs
and so on.
Comment on lines
+1142
to
+1144
| ui/generics/issue-5997-outer-generic-parameter/issue-5997-enum.rs | ||
| ui/generics/issue-5997-outer-generic-parameter/issue-5997-struct.rs | ||
| ui/generics/issue-5997-outer-generic-parameter/issue-5997.rs |
Comment on lines
+856
to
+857
| ui/cross-crate/issue-38875/auxiliary/issue-38875-b.rs | ||
| ui/cross-crate/issue-38875/issue-38875.rs |
There was a problem hiding this comment.
The original issue was named "constant evaluation error" points to nothing when crossing the crate boundary, the solution PR was implement lazy-loading of crate's sources, could you rename this for that? Perhaps the root one should be
- tests/ui/cross-crate/lazy-load-externs/const-issue-38875.rs
|
@bors r- (for renaming requests) |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #125379) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @petrochenkov