Resolve elided lifetimes in assoc const to static if no other lifetimes are in scope #125258
+96
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
changed the title
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
static-if-no-lt
branch
from
130a9d0
to
2c09825
Compare
|
☔ The latest upstream changes (presumably #124417) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the change to elided lifetime resolution in associated consts subject to FCP here: #125190 (comment)
Specifically, walk the enclosing lifetime ribs in an associated const, and if we find no other lifetimes, then resolve to
'static.This needs test, so marking as draft and ghost.
r? @ghost