New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Add a note to inspection.partial_dependence() about different results when using brute and recursion method #28595
Open
lamdang2k
wants to merge
9
commits into
scikit-learn:main
Choose a base branch
from
lamdang2k:doc_partial_dependence
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamdang2k
changed the title
DOC - Add a note to inspection.partial_dependence() about different results when using brute and recursion method
ENH Add a note to inspection.partial_dependence() about different results when using brute and recursion method
Mar 7, 2024
lorentzenchr
changed the title
ENH Add a note to inspection.partial_dependence() about different results when using brute and recursion method
DOC Add a note to inspection.partial_dependence() about different results when using brute and recursion method
Mar 25, 2024
Hi @lamdang2k are you still working on this ? If not, I would like to open a PR linking to this and fixing the failing checks. |
Go ahead, thanks for taking over this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #27441
What does this implement/fix? Explain your changes.
Add a note for the case of correlated predictors the
sklearn.inspection.partial_dependence()
function gives different answers formethod = "recursion"
andmethod = "brute"
Any other comments?