Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for stm32c011j4m6 #2359

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

alexnagelberg
Copy link
Contributor

@alexnagelberg alexnagelberg commented May 5, 2024

  • Adds C011J(4-6)Mxx variants

@fpistm fpistm changed the title Adding support for stm32c011j4m6 (j4/j6XX should be supported but unt… Adding support for stm32c011j4m6 May 6, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 6, 2024
@fpistm fpistm added this to the 2.8.0 milestone May 6, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexnagelberg
Thanks for this PR.
Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).
Plus a small update of the ldscript to be generic.
Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files

variants/STM32C0xx/C011J(4-6)M/ldscript.ld Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review May 6, 2024
@alexnagelberg
Copy link
Contributor Author

Hi @alexnagelberg

Thanks for this PR.

Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).

Plus a small update of the ldscript to be generic.

Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files

@fpistm Sure, although this ldscript was generated by cubemx, so I'm not sure how to get it to include but will play around. Just a heads up that this PR is not ready so I put it in draft, mostly as a reminder to myself to finish it.

@alexnagelberg
Copy link
Contributor Author

Added remaining changes. Still in testing with my new chip.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor update to avoid astyle issue.

README.md Outdated Show resolved Hide resolved
variants/STM32C0xx/C011J(4-6)M/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32C0xx/C011J(4-6)M/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32C0xx/C011J(4-6)M/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32C0xx/C011J(4-6)M/generic_clock.c Outdated Show resolved Hide resolved
@alexnagelberg
Copy link
Contributor Author

One thing I'm concerned about with the existing code is default generic Serial is I believe pointed at the same pins which will only work for half-duplex. May want to use the same pin configuration as the bootloader uses for USART1. I've been having trouble getting it to work even with pin changes though.

@fpistm
Copy link
Member

fpistm commented May 13, 2024

Pins defined in the variant generic have no link with the built-in bootloader. Generic files could not be changed as they are automatically generated.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved May 13, 2024
@fpistm fpistm marked this pull request as ready for review May 13, 2024 12:22
@fpistm
Copy link
Member

fpistm commented May 13, 2024

@alexnagelberg If it is ok for you I will merge the PR.

@alexnagelberg
Copy link
Contributor Author

@alexnagelberg If it is ok for you I will merge the PR.

@fpistm Serial doesn't appear to be setup correctly but everything else appears working. I'm okay with it being merged and staying yellow heart.

@fpistm
Copy link
Member

fpistm commented May 13, 2024

Serial doesn't appear to be setup correctly

The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work.
What is the issue? wrong speed ? ...

@fpistm
Copy link
Member

fpistm commented May 27, 2024

Serial doesn't appear to be setup correctly

The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work. What is the issue? wrong speed ? ...

Looking at the package, by default Serial is mapped on USART1 Using PA0 and PA1 but they are both on the same pin. So to test you can try to redefine the RX on PC14 before calling begin()

Serial.setRx(PC14);

@fpistm
Copy link
Member

fpistm commented May 27, 2024

I've squash you PR and update the clock config to use LL instead of HAL. This allows to save 1K flash.

@fpistm
Copy link
Member

fpistm commented May 27, 2024

Codespell issue can be safely ignored (see #2379).

@fpistm fpistm merged commit 91671d4 into stm32duino:main May 28, 2024
23 of 24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants