Mitigate Server-side Reflected XSS Vulnerability in Alerts Route #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so good! thanks for the fix! Our first XSS ever! We are testing and will merge soon. |
|
Hi there, any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#376
Changes proposed
This PR mitigates a server-side reflected XSS vulnerability in the /alerts// route by sanitizing user inputs before returning them to the webpage. This has been accomplished by using Flask's escape() method on the user input data before adding it to the response.
The affected parameters alert_timestamp, alert_ID, profile_ip, and tw_name are now properly escaped to prevent potential cross-site scripting attacks.
Check List (Check all the applicable boxes)
Note to reviewers
Please ensure the sanitization has no effect on the overall functionality and output of the set_alerts route. If you encounter any issues, let me know and I'll make the necessary adjustments.